Add username field on sign up #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Jun 28, 2018
|
It's required at the moment, that could certainly be amended. |
|
@cldambrosio It's not a massive thing, but I wonder if anyone else has a view @orangewolf @mjgiarlo |
|
I'm 🆗 with this change, even with the name field being required. |
|
@geekscruff I'm ok with it either way as well. |
ghost
approved these changes
Jun 29, 2018
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Add name field on sign up in order to prepopulate the contact form with user name instead of an email address.
We implemented this change in our fork of Hyku.
@samvera/hyrax-code-reviewers