Switch from Poltergeist to headless Chrome #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
headless_chrome
branch
3 times, most recently
from
48b6a2a
to
581f343
Compare
jcoyne
force-pushed
the
headless_chrome
branch
7 times, most recently
from
0a17245
to
190a0a2
Compare
|
Build is failing: You should put chromedriver into PATH: |
jcoyne
force-pushed
the
headless_chrome
branch
2 times, most recently
from
433568f
to
3b8b867
Compare
Poltergeist is no longer maintained Rails 5.1 introduces ActionDispatch::SystemTestCase which should allow our feature tests to be speed up when this is done: rspec/rspec-rails#1813
mjgiarlo
approved these changes
Mar 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poltergeist is no longer maintained
Rails 5.1 introduces ActionDispatch::SystemTestCase which should allow
our feature tests to be speed up when this is done:
rspec/rspec-rails#1813
@projecthydra-labs/hyrax-code-reviewers