Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails 5.2 to the build matrix #3030

Closed
wants to merge 1 commit into from
Closed

Add Rails 5.2 to the build matrix #3030

wants to merge 1 commit into from

Conversation

no-reply
Copy link
Contributor

@no-reply no-reply commented May 4, 2018

Rails 5.0.x is no longer supported. Drop it from the build matrix and replace it with 5.2.

@samvera/hyrax-code-reviewers

Rails 5.0.x is no longer supported. Drop it from the build matrix and replace it
with 5.2.
@cjcolvar
Copy link
Member

cjcolvar commented May 5, 2018

I'm pretty certain rails 5.2 isn't going to work until active-fedora gets a release that includes samvera/active_fedora#1312. Other dependencies may need patches as well.
I think hydra-pcdm is okay but I believe hydra-works has a couple small issues to resolve. Even then Hyrax will need to upgrade to that version of ActiveFedora: #2256 and the other dependencies.

I guess I'm wondering if we should wait on this until we know that we're closer to a PR adding support for rails 5.2. That way we wouldn't be spending extra travis concurrent builds for something we know is going to fail.

@no-reply
Copy link
Contributor Author

no-reply commented May 5, 2018

@cjcolvar yes, it's definitely not my intent that we will change the build matrix until this is passing. This is here mainly to provide a target and a place for discussion.

This PR represents the intent to drop support for Rails 5.0 in a future release. We need to talk about how to approach that drop, what it means for our versions, etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants