comet: decouple Derivatives from Characterization #5778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
commented
Jul 14, 2022
| @@ -119,6 +119,10 @@ class Publisher | |||
| # unique id), AND a `:user` (the ::User responsible for the update). | |||
| register_event('collection.membership.updated') | |||
|
|
|||
| # @since 3.5.0 | |||
There was a problem hiding this comment.
i plan to backport this quickly to the 3.x stable branch, so this is the appropriate release target
no-reply
force-pushed
the
decouple-char-deriv
branch
from
3cd9e04
to
c0c5fd1
Compare
the tight coupling of Derivative generation to the Characterization background job makes it hard to customize derivatives processing without changing characterization behavior. this takes a hack at decoupling the two by routing derivatives through an event handler. instead of enqueing the derivatives job directly, the CharacterizeJob now simply reports that it has characterized the given file_id within the file_set. it also provides its path hint, in case a listener wants to log or reuse that hint. we then add a listener to do the work of actually characterizing. this is a bit of indirection, but has a lot of benefits in flexibility: you no longer need to rewrite characterization behavior to customize derivatives handling.
dunn
approved these changes
Jul 14, 2022
no-reply
pushed a commit
to surfliner/surfliner-mirror
that referenced
this pull request
Jul 19, 2022
this event was introduced in samvera/hyrax#5778; but we haven't yet been able to backport it. introduce it here until it can get into the 3.x line.
no-reply
pushed a commit
to surfliner/surfliner-mirror
that referenced
this pull request
Jul 19, 2022
publish jobs when files are characterized, per samvera/hyrax#5778. when these jobs are published, check if the characterized file is a pcdm:OriginalFile. if so, enqueue a derivatives job; else do nothing.
dlpierce
added a commit
that referenced
this pull request
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the tight coupling of Derivative generation to the Characterization background
job makes it hard to customize derivatives processing without changing
characterization behavior.
this takes a hack at decoupling the two by routing derivatives through an event
handler. instead of enqueing the derivatives job directly, the CharacterizeJob
now simply reports that it has characterized the given file_id within the
file_set. it also provides its path hint, in case a listener wants to log or
reuse that hint.
we then add a listener to do the work of actually characterizing. this is a bit
of indirection, but has a lot of benefits in flexibility: you no longer need to
rewrite characterization behavior to customize derivatives handling.
@samvera/hyrax-code-reviewers