dynamic forms that load flexible metadata #6844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This work solely focused on the UI elements needed to build out the ability to import a metadat profile. This heavily relies on backend functionality to complete.
This commit will relocate the Metadata Profiles link to Repository Content. We also refactor the modal to make it show up better.
Options were loaded in the modal previously. When this logic was moved into a controller, it became confusing due to other definitions of `available_admin_sets`. Additionally, add a validation to ensure that a work type is selected.
We need a nil guard for @admin_sets_for_select in case other partials use the @admin_sets_for_select instance variable.
In this commit we updated code to support dynamic rendering for attribute rows
This commit will add a few different conditions for populating the
label. If the label is a string we'll simply set that as the label.
ex. `label: 'My Label'`
If the label is a hash we'll look for the key that matches the current
locale.
ex. `label: { en: 'My Label', es: 'Mi Etiqueta' }`
If the locale is not found it will fall back to en as the default, but
if en isn't found it will just use the first value in the hash.
ex. `label: { es: 'Mi Etiqueta', fr: 'Mon Étiquette' }`
kirkkwang
force-pushed
the
flexible_forms
branch
from
631732c
to
e060c84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds dynamic dataloading to form object
@samvera/hyrax-code-reviewers