Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency issue upgrading to Symfony 6.2 #55

Closed
mcrauwel opened this issue Jan 17, 2023 · 7 comments
Closed

dependency issue upgrading to Symfony 6.2 #55

mcrauwel opened this issue Jan 17, 2023 · 7 comments

Comments

@mcrauwel
Copy link

Symfony 6.2 requires psr/cache ^2 or ^3 while phpflickr requires psr/cache ^1

Composer update snippets...
When upgrading from Symfony 5.4 to 6.2

    - symfony/cache[v6.2.0, ..., v6.2.4] require psr/cache ^2.0|^3.0 -> found psr/cache[2.0.0, 3.0.0] but it conflicts with your root composer.json require (^1).

When changing the requirement for psr/cache from ^1 -> ^3

    - samwilson/phpflickr[4.14.0, ..., 4.14.3] require psr/cache ^1.0 -> found psr/cache[1.0.0, 1.0.1] but it conflicts with your root composer.json require (3.*).
@samwilson
Copy link
Owner

Hmm. Maybe we can do "psr/cache": "^1|^2|^3"? What are the non-BC changes that they've made to the psr/cache API? I think we're using only CacheItemPoolInterface::getItem(), CacheItemPoolInterface::save(), CacheItemInterface::set() and CacheItemInterface::expiresAfter().

@mcrauwel
Copy link
Author

Looking at the releases page, they compatibility to PHP8 in version 2
And they added return types in version 3

@samwilson
Copy link
Owner

Well that sounds hopeful. I'll test later and see how it goes. Maybe it'll be super simple. :-)

samwilson added a commit that referenced this issue Jan 18, 2023
Also updates the cache implementation used in the example file
because tedvium/stash doesn't yet support the new versions of
psr/cacche.

Fix a bug with the cache example which was using the 'test'
API call, which declares itself as 'nocache'. Instead, call
it manually (with the default of nocache=false).

Refs #55
@samwilson
Copy link
Owner

I've updated the psr/cache version requirement, see what you think of #56.

@mcrauwel
Copy link
Author

mcrauwel commented Jan 18, 2023

that does the trick!

...
-        "psr/cache": "^1",
+        "psr/cache": "^3",
...
-        "samwilson/phpflickr": "^4.14",
+        "samwilson/phpflickr": "dev-cache-update",
...
-        "symfony/asset": "5.4.*",
-        "symfony/console": "5.4.*",
-        "symfony/dotenv": "5.4.*",
-        "symfony/expression-language": "5.4.*",
+        "symfony/asset": "6.2.*",
+        "symfony/console": "6.2.*",
+        "symfony/dotenv": "6.2.*",
+        "symfony/expression-language": "6.2.*",
...

works like a charm!

samwilson added a commit that referenced this issue Jan 18, 2023
Also updates the cache implementation used in the example file
because tedvium/stash doesn't yet support the new versions of
psr/cacche.

Fix a bug with the cache example which was using the 'test'
API call, which declares itself as 'nocache'. Instead, call
it manually (with the default of nocache=false).

Refs #55
@samwilson
Copy link
Owner

Great, thanks for testing. I've made a new release.

@mcrauwel
Copy link
Author

🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants