types: add Symbol #134
types: add Symbol #134
Conversation
|
@davidchambers will this change require adding Symbol to sanctuary-type-classes as well? |
I don't think so. What do you have in mind? |
index.js
Outdated
| @@ -713,6 +713,12 @@ | |||
| //. Type comprising every primitive String value. | |||
| var String_ = NullaryTypeWithUrl('String', typeofEq('string')); | |||
|
|
|||
|
|
|||
index.js
Outdated
|
|
||
| //# Symbol :: Type | ||
| //. | ||
| //. Type comprising every primitive Symbol value. |
There was a problem hiding this comment.
Is it necessary to use "primitive" here?
There was a problem hiding this comment.
An artifact of copying. There is no boxed version of Symbol thus no need to differentiate it.
Though it is a primitive.
index.js
Outdated
| //# Symbol :: Type | ||
| //. | ||
| //. Type comprising every primitive Symbol value. | ||
| var Symbol_ = NullaryTypeWithUrl('Symbol', typeofEq('symbol')); |
There was a problem hiding this comment.
Is there a reason to favour typeofEq('symbol') over typeEq('Symbol'), or are the expressions equivalent?
There was a problem hiding this comment.
They should be equivalent. I would think the typeofEq would be slightly faster. I don't know if there are any benchmarks though.
index.js
Outdated
| @@ -793,6 +800,7 @@ | |||
| RegExp_, | |||
| StrMap(Unknown), | |||
| String_, | |||
| Symbol, | |||
|
Updated |
Closes #133