sanctuary-type-identifiers@3.0.0 #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidchambers
commented
Nov 3, 2019
| eq (Z.equals (Array.prototype, Array.prototype), true); | ||
| delete Maybe['@@type']; |
There was a problem hiding this comment.
This delete statement is required to prevent Maybe from being treated as a member of a type that lacks a fantasy-land/equals method. I will remove it when I upgrade the sanctuary-maybe dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/sanctuary-js/sanctuary-type-identifiers/releases/tag/v3.0.0
We wish to update and release sanctuary-type-classes before updating the various ADT packages, because they depend on this package. As a result, this project's test suite will temporarily rely on the fact that
Object#fantasy-land/equalshappens to correctly determine equality ofIdentity a,Maybe a, andPair a bvalues.