-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added map functionality and additional attributes #213
Conversation
@torstenknoefel - Thank you for your work! At what interval are you updating the map and when? Based on the mower state? I like the feature but I see a risk here of getting blocked by the Bosch API if we increase the API calls. I think we can merge this, but keep the feature disabled by default. Users that need it can enable it through the integration config page. |
Just noticed something... I don't think it will work correctly with multiple mowers. The SVG uses a static file/path. So the SVG will be overwritten with multiple mowers. |
This pull request is stale because it has been open for 14 days with no activity. |
Hi! I'm interested in working on this PR. What needs to be done before merging? @jm-73 |
Hi @mateusz-lichota! We have not received any replies to my questions in this PR. To summarize what's discussed/asked:
I just released version 5.7.0 ; so also sync with latest version on develop branch. Just let me know when all is implemented/fixed so I (and maybe others) can test it. |
Regarding your concerns:
I'll copy the map-related changes (discarding the alert-related stuff, which should arguably be a separate PR) from @torstenknoefel 's branch into my fork and make those changes, then open a new PR |
This pull request is stale because it has been open for 14 days with no activity. |
This pull request was closed because it has been inactive for 30 days since being marked as stale. |
I have married up your repo (V 5.5.0) with the code from this repo: https://github.com/SmarthomeAddicted/Indego-Integration.
(I used diff to add the missing code and adapted slightly.)
This relates to my feature request #212