Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using negative margins on Firefox #248

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Stop using negative margins on Firefox #248

merged 1 commit into from
Dec 1, 2023

Conversation

nigelmegitt
Copy link
Contributor

@nigelmegitt nigelmegitt commented Oct 17, 2023 •
edited by palemieux
Loading

Duplicated from @robertbryer 's pull request bbc#21 .

Workaround for #247, should be removed when Firefox's bug is fixed.

Closes #247

@palemieux
Copy link
Contributor

palemieux commented Dec 1, 2023 •
edited
Loading

@nigelmegitt Can you provide a file that triggers the issue? It should ideally be added to https://github.com/w3c/imsc-tests.

NVM, linepadding-001, linePadding1 and linePadding4 exhibit a difference.

@palemieux palemieux merged commit d672018 into sandflow:master Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firefox bug with negative margins
2 participants
@nigelmegitt @palemieux