-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjacent tts:textCombine spans are combined into a single span #232
Comments
an alternative or additional fix would be
|
Interesting. I'm fairly certain that I didn't test what would happen with |
This feels most natural since |
Co-authored-by: Nigel Megitt <nigel.megitt@bbc.co.uk> Co-authored-by: Simon Hailes <simon@yellaumbrella.tv>
When there are two adjacent spans with tts:textCombine=all, they are combined into a single span containing the text from both.
when debugging, it seems that _isd_element is undefined on both spans (not sure why), and so are equal.
It would seem prudent to replace (in html.js):
with
this may mean there are other times when spans are combined when they should not be?
The text was updated successfully, but these errors were encountered: