Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of empty ISDs in SRT writer #331

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Fix handling of empty ISDs in SRT writer #331

merged 1 commit into from
Sep 8, 2021

Conversation

palemieux
Copy link
Contributor

Closes #330

@palemieux palemieux self-assigned this Sep 7, 2021
@palemieux palemieux mentioned this pull request Sep 7, 2021
Closed
andreastai
andreastai approved these changes Sep 8, 2021
View reviewed changes
Copy link
Collaborator

@andreastai andreastai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested SRT conversion with IMSC 1 timing test files. Looks good to me. Thanks for the fix!

@xchange11 xchange11 removed their request for review September 8, 2021 13:22
xchange11
xchange11 approved these changes Sep 8, 2021
View reviewed changes
Copy link
Collaborator

@xchange11 xchange11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested SRT conversion with IMSC 1 timing test files. Looks good to me. Thanks for the fix!

@palemieux palemieux merged commit f8e91d9 into master Sep 8, 2021
@palemieux palemieux deleted the issues/0330-fix-timing-handling-srt branch December 2, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreastai andreastai andreastai approved these changes

@xchange11 xchange11 xchange11 approved these changes

Assignees

@palemieux palemieux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timing Support in VTT and SRT Writer
3 participants
@palemieux @xchange11 @andreastai