Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBC Scaling Not Applied to All BCs #307

Closed
gphlipot opened this issue Jun 25, 2018 · 0 comments
Closed

DBC Scaling Not Applied to All BCs #307

gphlipot opened this issue Jun 25, 2018 · 0 comments
Assignees

Comments

@gphlipot
Copy link

When using the DBC boundary conditions with 'Scale BC Dofs' set to true, the scaling does not get applied to all of the dirichlet boundary condition rows. It looks like the scaling is only applied to some of the node sets.

@ikalash ikalash self-assigned this Jun 25, 2018
ikalash added a commit that referenced this issue Jun 26, 2018
for non-constant scaling.

In this case, we get either the diagonal value of the Jacobian,
or the absolute value of the rowsum, compute the maximum, and
scale the DBCs by this value.  As the Jacobian evolves, so does
the scaling; therfore it is not necessary to specify a priori
a scaling value in the input file.

A bug was discovered in the DBC scaling today (see issue #307)
that should be fixed prior to expecting the new option
to work robustly for all problems.
ikalash added a commit that referenced this issue Jul 1, 2018
Please give it a try, @gphlipot, and close it if things work
as expected with this fix.
@gphlipot gphlipot closed this as completed Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants