-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start using Formatting Tools #38
Labels
Comments
For LCM we try to follow the Google C++ coding standards. For formatting, I use Eclipse with the BSD-Allman style of formatting. I'll check clang-format to see what it does. |
Google is one of its styles, and is the one I base my format on. One thing that might be of use is to choose a representative C++ file and we can look at it under different settings. |
lxmota
added a commit
that referenced
this issue
Mar 15, 2017
following the Google C++ style guide: https://google.github.io/styleguide/cppguide.html The configuration has some minor deviations that deal with white space. (#22, #38)
lxmota
added a commit
that referenced
this issue
Mar 25, 2017
lxmota
added a commit
that referenced
this issue
Apr 27, 2017
lxmota
added a commit
that referenced
this issue
Nov 15, 2017
reveaed while using clang-format. [#38]
lxmota
added a commit
that referenced
this issue
Aug 14, 2018
Use clang-format to format almost all the code under the LCM subdirectory. This uncovered some inconsistencies with #include statements that were fixed. The main exception to this reformatting is the crystal plasticity model. Jay Foulk, Coleman Alleman, Guy Bergel, and Dave Littlewood would gang up and kill me if I touch that code in this manner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've created a Wiki page here:
https://github.com/gahansen/Albany/wiki/Formatting-Tools
Which describes
clang-format
, a tool to automatically format C++ files, andxmllint
, a tool which automatically formats XML files.Based on discussion in the weekly phone call, possible uses of these tools include:
clang-format
styles that accurately match our own style(s)src/LCM/.clang-format
clang-format
to also clean up the styling of itxmllint
to clean up its indentationclang-format
to most of the sourcexmllint
to most of theinput.xml
filesAs always, this issue is here to gather feedback on this. We may start to iterate on a
.clang-format
file in the near future.The text was updated successfully, but these errors were encountered: