Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting of Workset Size in input file for ATO::2Matl tests does not appear to be working #48

Closed
ikalash opened this issue Feb 1, 2017 · 7 comments
Assignees
Labels

Comments

@ikalash
Copy link
Collaborator

ikalash commented Feb 1, 2017

A few of the ATO tests began to fail last night with the change in default workset size due to having been baselined against a gold file generated with workset size = 50 and tight exodiff tolerances. I attempted to fix the tests by setting the workset size = 50 in the input file (adding the line under "Discretization) but it does not appear to work -- when I print workset size in Albany::IOSSSTKMeshStruct, it is > 50. I have verified that commit 2eb2559 (change in workset size default value) is what broke this test. @ibaned , can you please look into why the workset size value specified in the input file does not overwrite the default value in the code for these tests?

@ibaned
Copy link
Contributor

ibaned commented Feb 1, 2017

I think you should consider it a separate bug that you get a different answer with a different workset size. Is there any known reason why workset size could affect results at all ? Anyway, I'll look at the input parameter issue.

@ikalash
Copy link
Collaborator Author

ikalash commented Feb 1, 2017

I agree. This is a question for @jrobbin, the author of ATO. I'll take this up with him. It looks to me like the solutions are slightly off in the 4th decimal point with the different workset size. I don't know enough about the physics and gold file to say if this is significant and why this is workset dependent. If you could look at the input issue for now, that would be great. We want the user to be able to control the workset size from the input file for all physics in Albany, if this is desired.

@djlittl
Copy link
Contributor

djlittl commented Feb 1, 2017 via email

@ibaned
Copy link
Contributor

ibaned commented Feb 1, 2017

Why are these tests only active if Albany is not in 64-bit mode ? This is the fifth time I've had to rebuild Albany trying to compile ATO...

@ikalash
Copy link
Collaborator Author

ikalash commented Feb 1, 2017

@jrobbin is the author of ATO and the one who put in that logic so he can best answer this question. My guess is the logic was put in as a precaution, since the original Epetra-only code was not meant to run for huge problem requiring 64-bit int GOs. I will check if the examples can be activated in a 64-bit build, and turn them on there, if they work. Sorry for the frustrations this is causing, @ibaned ....

@ibaned
Copy link
Contributor

ibaned commented Feb 1, 2017

@ikalash it looks like the parameter was just in the wrong place in the input file. ATO is confusing because it has "Discretization" lists for all the subproblems, and then a separate one outside of "Problem". Commit 04592a5 should fix this.

@ibaned ibaned closed this as completed Feb 1, 2017
@ikalash
Copy link
Collaborator Author

ikalash commented Feb 2, 2017

I see -- I missed this detail. Thanks for fixing it, @ibaned !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants