Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extraneous TpetraBuild global bool variable #75

Closed
lxmota opened this issue Feb 26, 2017 · 3 comments
Closed

Remove extraneous TpetraBuild global bool variable #75

lxmota opened this issue Feb 26, 2017 · 3 comments
Labels
bug infrastructure

Comments

@lxmota
Copy link
Contributor

lxmota commented Feb 26, 2017

This global variable pollutes all executables even when they have nothing to do with Tpetra/Epetra.

At least I'll try to get rid of it from LCM executables.
lxmota added a commit that referenced this issue Feb 26, 2017
@lxmota
LCM: Remove TpetraBuild bool global variable from these executables
9c08ec1 
that have nothing to do with Tpetra/Epetra (#75).
lxmota added a commit that referenced this issue Feb 26, 2017
@lxmota
LCM: Some executables do not depend on BGL. Reorganize (#75).
62aa11d
lxmota added a commit that referenced this issue Mar 8, 2017
@lxmota
LCM: More clean ups of Schwarz Alternating. (#53)
93aab43 
Remove T suffix to denote Tpetra from variable and functions names
as it clutters notation and is unnecessary here. (#22, #75)
lxmota added a commit that referenced this issue Mar 8, 2017
@lxmota
LCM: More removal of T suffix to denote Tpetra from variable and
6f2ab81 
function names as it clutters notation and is unnecessary here.
(#22, #75)
lxmota added a commit that referenced this issue Mar 26, 2017
@lxmota
LCM: Remove more Epetra tests. [#22, #75]
aa6ec64
lxmota added a commit that referenced this issue Mar 26, 2017
@lxmota
LCM: Remove more Epetra tests. [#22, #75]
3c62866
lxmota added a commit that referenced this issue Mar 30, 2017
@lxmota
LCM: Remove Tpetra suffix for tests (they are all Tpetra). Remove
79a1979 
a few more Epetra tests. [#75, #98]
@bartgol
Copy link
Collaborator

bartgol commented Jul 25, 2018

I believe this is now solved. Should we close?

@tjfulle
Copy link
Contributor

tjfulle commented Jul 25, 2018

I believe #261 makes this issue obsolete.

@bartgol
Copy link
Collaborator

bartgol commented Jul 25, 2018

Agreed. Closing.

@bartgol bartgol closed this as completed Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tjfulle @bartgol @lxmota