STK fixes #967
Merged
STK fixes #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening the PR. I forgot I could have forked albany in my personal account, and issue a pr from the fork... |
|
is this good to push? |
|
I am still running the testsuite (corePDEs passed). However, given that this was a matter of compilation errors, and given that we don't check output files content in our tests (something we should do at some point), I don't foresee any failure, so we could probably merge right away. |
|
sounds good thanks |
|
thanks @lbertagna and @jewatkins ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks good to me, thanks Luca