Build with cmake #18
Merged
Build with cmake #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petebachant
approved these changes
Mar 15, 2020
kmruehl
reviewed
May 1, 2020
There was a problem hiding this comment.
@petebachant same, and I agree. Having one Makefile, instead of one for each platform, seems like a huge improvement to me.
|
@jcokemurray can you review and approve this PR? |
Travis OSX image provides 3.11.3, Linux (bionic) provides 3.12.4
PGI Fortran doesn't like that
Should have universal support across GNU, Intel, PGI compilers
-O2 should be in dialect, not in bounds-check set of flags
These are outdated and should be replaced with instructions to build with CMake in Windows
|
Rebased onto the tip of |
|
Works for me. Cmake would definitely be an improvement over the manual Makefile approach... |
jcokemurray
approved these changes
May 5, 2020
|
@jcokemurray thanks for reviewing. @whophil merging this PR now. |
This was referenced May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous build system of platform-specific Makefiles requiring manual modification was pretty hairy. Here is a new build setup which uses CMake, with the following advantages:
CMakeLists.txt) for all platforms and optionsThis will require some updates to the compile instructions, but those will conflict with #17. So let's merge that one first, and then I'll fix this PR up.