Increase support size #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paired with Julia Plews for part and Alejandro Mota for the rest.
|
Also, added optional support to link with the debugging library ElectricFence . Very handy for catching some memory errors. |
japlews
reviewed
May 7, 2020
| @@ -4,6 +4,7 @@ project(LGR VERSION 3.0.0 LANGUAGES CXX) | |||
|
|
|||
| option(LGR_ENABLE_CUDA "Build GPU support" OFF) | |||
| option(LGR_ENABLE_UNIT_TESTS "Enable unit tests" ON) | |||
| option(LGR_ENABLE_EFENCE "Build with ElectricFence support" OFF) | |||
There was a problem hiding this comment.
Have you tried Clang's built-in address sanitizer?
There was a problem hiding this comment.
No! Need to learn hot to use that!
japlews
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed allocation error for shape functions to take into account that points can have variable support size.