Bugfixes for Example notebooks. #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes errors like: AttributeError: module 'jinja2' has no attribute 'evalcontextfilter' caused by changes to the jinja2 API when moving from version 2->3. Note: this breaks compatibility with jinja2 vesion 2.x, so if you get errors about jinja2 not having the attribute 'pass_eval_context' then you just need to update jinja2.
Following the updates to elementary error generator construction (now closely following the taxonomy paper), the elementary error generator basis should usually be the un-normalized (traditional) Pauli-product basis when the state space is composed of qubits. This gives the intuitively expected coefficients, e.g. 0.5pi for the Hamiltonian projection of a pi/2 rotation gate. This commit updates the report quantities giving the projections onto gates and error generators to use the 'PP' basis whenever the model space is entirely qubits, and to only fall back on the model's superoperator basis in other cases. This means that the intuitive error generator coefficients and gate decomposition should occur within reports for qubit models. However, in other (e.g. qutrit model) cases, the code still falls back to the model basis - and this may not be what we actually want. FUTURE work: fix/improve the elementary errorgen basis selection for non-qubit models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #240.