Bugfix matrixmod2 determinism #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_rb_circuit. (Just a single line removed.)
These functions previously just called _np.random(...) and so their pseudo-randomness could not be nicely seeded and easily made deterministic. This commit fixes this issue, adding `rand_state` arguments to several matrixmod2.py functions and updating the use of these function within matrixmod2.py and compilers.py (this is the only other modules where these functions are used within pyGSTi). All added `rand_state` arguments can be set to a `numpy.random.RandomState` object or left as None (the default), in which case a new random state is created.
|
Took a look through the changes and this all looks good to me, fwiw. |
sserita
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to seed Clifford compilations used in RB so deterministic behavior results
Plumbs a
RandomStateobject through functions incompilers.pyandmatrixmod2.pyso that the randomness used therein can be seeded properly. This PR also removes a duplicatedone_editingcall inrandomcircuit.pythat I stumbled upon as I was making the main updates.I think (& hope) that this PR may fix a long-standing issue of the pyGSTi unit tests occasionally failing because of an RB circuit mismatch. This erroring could be "fixed" by simply rerunning the unit tests again, which was suspicious and unnerving.