Feature wildcard serialization #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dcard budgets. Updates WildcardBudget to inherit from NicelySerializable and updates what is stored within GST Estimate objects to be a *serialized* WildcardBudget rather than the object itself. This allows the Estimate to serialize itself without any modification, using the standard metadir framework. On the other hand, it necessitates updating the report construction (in factory.py) to initialize a WildcardBudget object from the Estimate's serialization, which is not performed. This update may therefor break user code that assumes that estimate.extra_parameters['unmodeled'] is a WildcardBudget.
…reports. Updates estimate construction code to serialize 'wildcard1d' budgets, and updates reporting code to allow for a JSON-serialized wildcard budget within an estimate object instead of the object itself.
sserita
reviewed
Nov 21, 2022
sserita
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to serialize results objects to disk or MongoDB that contain wildcard budgets
This seems useful for obvious reasons. As a side effect,
Estimateobjects are updated to hold serialized wildcard budget objects instead of the objects themselves. This could break external code that extracts wildcard budgets from result objects.