Feature fidsel performance #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 2, 2022 19:29
This commit introduced a new greedy search algorithm leveraging the same low-rank update tricks that we use in other parts of the experiment design codebase. This also introduces a new deduping routine specialized to the case where our gate set only generates the clifford group in which we leverage the fact that the PTMs of clifford operations are signed permutation matrices. This coupled with hash table magic (using python dictionaries which use them internally) gives an amortized O(N) deduping routine in this case.
Add additional flexibility to the candidate set specification by essentially adopting a slightly modified version of the code used for germ selection. This now allows for specifying a random set of circuits at a particular length instead of always including all up that length (which grows quickly combinatorically).
minor typo fix
restore backwards compatibility by allowing max_fid_length as an argument still, but mapping it's behavior to the equivalent one using candidate_fid_counts and raise a warning so the user knows what is going on.
Updates the docstring for germ selection to include explanations of some new options relevant to low-rank update based greedy search.
Removes a bunch of print statements that were included for debugging and also moves some of this information into appropriate logging functions/exception handling.
Fixes linting error from undefined variable.
sserita
requested changes
Nov 21, 2022
enielse
approved these changes
Nov 22, 2022
| if final_test_fiducial_list: | ||
| printer.log('Final test of the candidate prep fiducial lists passed.', 1) | ||
| else: | ||
| printer.log('Final test of the candidate prep fiducial lists failed.', 1) |
There was a problem hiding this comment.
The above block is repeated 8 (I think) times within this function, which makes me think it'd be worth consolidating it to a nested function.
There was a problem hiding this comment.
I refactored this as suggested.
Refactors the deduping code to combine the two separate functions for deduping the candidate fiducial list into a single one that branches on the case where we are assuming a Clifford gate set. Also refactors a printing subroutine to reduce amount of repeating. Finally adds some docstring and debug clean-ups.
|
Thanks for the comments and feedback, @sserita and @enielse . I have refactored and updated the code in accordance with your suggestions. I'll plan on merging this in once I get a clean set of unit tests back on the latest commit (@sserita, I think you'll also need to approve the PR before merging is unblocked). |
sserita
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch implements a new greedy search algorithm that leverages the same low-rank update tools now available for germ selection and FPR. This is specifically useful for accelerating fiducial selection for many-qubit systems in the 4+ qubit range (for 3 or less the existing algorithms seem to run quick enough for most applications). This new greedy search algorithm only works with an objective function based on the psuedoinverse-trace. Other notable changes in this branch: