Bugfix more numpy124 stuff #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 3, 2023 19:39
Numpy doesn't like setting a slice of an array with an iterable anymore it seems, so cast this to a numpy array with the correct shape.
the report test package was accidentally listed twice in extras so was being run twice by accident.
This results in the coverage test being re-run for every test module in extras which is unnescessary, and in any case we already do coverage tests as part of the main unit test package.
Fixes some broken unit tests due to a shape compatibility issue with numpy.
qibo unit tests are currently unusable because of import errors (related to numpy 1.24.0 issues on their end). Skip these tests for now.
sserita
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few more numpy 1.24.0/1.24.1 deprecation related problems. Also in this bugfix branch are fixes for some failing tests in the test_extras package (one related to hessians and another related to qibo import failures) and some minor CI fixes.