Bugfix neverending windows integers #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 19, 2022 22:13
The SharedMemory object from the multiprocessing.shared_memory module expects the size argument in its init to be an integer of the same type as the default python system value (on windows 32-bits) so add in an extra cast (this is likely a reversion).
Fix a dtype check that was comparing against the wrong type for numpy boolean values.
sserita
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straightforward bugfix related to the shared memory module of the multiprocessing library expecting default system integers for the size argument for some reason, which on windows are 32-bit. I think the second fix has already been subsumed by other numpy dtype fixes.