Add support for non-standard POVMs and qudits to write_empty_protocol_data #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patches the write_empty_protocol_data function to add in the previously missing support for non-standard POVMs and for standard qudit POVMs (i.e. with dimension >2). For qudits this also supports having qudits of different dimensions. Not included is anything for handling instruments, which will require some additional work if desired.
coreyostrove
changed the title
sserita
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR patches the bug reported in #321. Previously the function
pygsti.io.write_empty_protocol_datahad the assumptions of qubits and that the readout was done in the standard basis hardcoded in. This lead to unexpected behavior when using models (really processor specs) with non-standard readout or even qudits with standard readout for dim>2. This PR adds in support for both of these things. For qudits this includes support for mismatching dimensions on the subsystems. This currently doesn't support multiple POVMs, and for non-standard POVMs if there were more than one we currently simply take the first in the list.Let me know if you have any questions or concerns.