Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting #57

Merged
merged 17 commits into from
Apr 17, 2019
Merged

Linting #57

merged 17 commits into from
Apr 17, 2019

Conversation

robpkelly
Copy link
Contributor

  • Using flake8 for linting
  • CI runs linting phase before tests
  • Style errors will fail builds on beta & master branches
  • Syntax errors & undefined names will fail builds on all branches
  • Fixed undefined names (closes Undefined names (low priority) #54)

@robpkelly
flake8 config
27683b2
@robpkelly
Added linting requires target, renamed travisci requires target t…
a0e76e0 
…o `testing`
@robpkelly
Limited CI to run linting on package source
962c575
@robpkelly
Fixed simple typos, missing imports/args
56bc3f4
@robpkelly
Fixed unused symbols in TermForwardSimulator
04416c8 
Some usages were ambiguous enough that I'm not sure this is actually correct
@robpkelly
Fixed undefined symbols in CloudNoiseModel
c3bd7b4 
It looks like some symbols were leftover after refactoring from
construction.nqnoiseconstruction.build_nqnoise_model. I left unusable
logic commented out; I have no idea if what remains is in any way
correct.
@robpkelly
Fixed undefined names in algorithms.compilers
974da18
@robpkelly
Removed apparently unneeded usages of comm in idtreport.create_idle…
a471b42 
…tomography_report
@robpkelly
Fixed unused symbols in drift.estimate.likelihood_of_general_model
09ab4f6
@robpkelly
Merge branch 'develop' into feature-linting
8db223d
@robpkelly
cloudnoisemodel only imports from construction when needed
ea39a2f 
Apparently it's not needed very often, since it looks as though that
branch has never been run
@robpkelly
Merge branch 'develop' into feature-linting
c1af548
@robpkelly
Fixed undefined name in objects.spamvec
e0826b5
@robpkelly
Added more comprehensive flake8 config & split into seperate 'critica…
d76149b 
…l' config
@robpkelly
CI builds will not fail on non-critical linting errors
eb73044
@robpkelly
Linter CI script skips nonessential setup
fdcfa0d
@robpkelly
Fixed broken alias in Travis config
07f7488
@robpkelly
Copy link
Contributor Author

@enielse please check each undefined name fix carefully -- I made some educated guesses

@robpkelly robpkelly mentioned this pull request Apr 17, 2019
Merged
enielse
enielse approved these changes Apr 17, 2019
View reviewed changes
Copy link
Collaborator

@enielse enielse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good here. Possible minor changes:

  • add "as _basis_build_vector" to change "from ..construction import basis_build_vector" in cloudnoise.py to avoid having imports in namespace?
  • change loop variable from p to dp in termevaltree.py because this is the derivative of a poly.

Both of these changes are just style, and don't affect functionality, so I'm approving.

@enielse enielse merged commit 130dc76 into develop Apr 17, 2019
@enielse enielse deleted the feature-linting branch April 17, 2019 14:45
@robpkelly robpkelly mentioned this pull request Apr 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enielse enielse enielse approved these changes

Assignees

@enielse enielse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robpkelly @enielse