Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker fix #6

Merged
merged 7 commits into from
Dec 22, 2022
Merged

docker fix #6

merged 7 commits into from
Dec 22, 2022

Conversation

mrbuche
Copy link
Contributor

@mrbuche mrbuche commented Dec 22, 2022

No description provided.

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 14.67% // Head: 14.67% // No change to project coverage 👍

Coverage data is based on head (ef0f158) compared to base (35b8a20).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage   14.67%   14.67%           
=======================================
  Files          50       50           
  Lines       12248    12248           
=======================================
  Hits         1797     1797           
  Misses      10451    10451           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mrbuche
Copy link
Contributor Author

mrbuche commented Dec 22, 2022

@dprohe fixed it here. Now there is just 1 docker.yml, tests the build on PR's, builds and pushes latest on your main, and does versioned image tags on releases. The original issue seemed to be Dockerfile related: (1) sdynpy+deps not ready for python 3.11, (2) one RUN instance seems to behave different here

@mrbuche
Copy link
Contributor Author

mrbuche commented Dec 22, 2022

@dprohe I added pushes to GitHub's container registry as well. Just figured out how to make it work today.

@dprohe dprohe merged commit f57526e into sandialabs:main Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants