Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default port matches endpoint; documentation improvements #39

Merged
merged 5 commits into from
Jul 31, 2024

Conversation

Aptimex
Copy link
Collaborator

@Aptimex Aptimex commented Jul 26, 2024

Default port for the configure command (i.e. --port) will now be set to whatever port was specified by the --endpoint command (instead of 51820), since that argument is already required and they usually need to be the same anyway.

Default route for the configure command is now a useful 0.0.0.0/0 instead of a useless 0.0.0.0/32, and --route is no longer a required argument (closes #35). Added a note to the README about how this default may create networking issues in some cases.

Various documentation improvements:

  • Server config is not compatible with other wireguard tools
  • Made more clear that clients can freely change their AllowedIPs
  • The endpoint and API addresses must be for the same server in the add server command
  • Servers will forget stuff that was configured via the API if they restart
  • Clarified limitations of clients added to non-first-hop servers (or not all of them)
  • Improved visual clarity of the example network diagrams

@Aptimex
Copy link
Collaborator Author

Aptimex commented Jul 26, 2024

@luker983 Can you check that I didn't say anything incorrect in the README changes? Other general thoughts are appreciated too

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
src/cmd/configure.go Outdated Show resolved Hide resolved
src/cmd/configure.go Outdated Show resolved Hide resolved
src/cmd/configure.go Outdated Show resolved Hide resolved
src/cmd/configure.go Outdated Show resolved Hide resolved
src/cmd/root.go Outdated Show resolved Hide resolved
@luker983
Copy link
Collaborator

Approved.

@Aptimex Aptimex merged commit c1f7d6a into main Jul 31, 2024
3 checks passed
@Aptimex Aptimex deleted the better-default-ports branch July 31, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WTF? Routes have a default but is required
2 participants