-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Program counter #14
Program counter #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to add an I_ prefix before input names and an O_ prefix before output names too if you can.
We will use the slow clock higher up, so no need to use it here.
component Slow_Clk | ||
Port ( Clk_in : in STD_LOGIC; | ||
Clk_out : out STD_LOGIC); | ||
end component; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont use the slow clock here. Just give in the clock directly, we'll handle the clock speed in one place
component Slow_Clk | |
Port ( Clk_in : in STD_LOGIC; | |
Clk_out : out STD_LOGIC); | |
end component; |
remove the rest of the signals for the slow clock too and use the clock input directly
Made the requested changes. Please check. |
Created a Program counter, a test bench for it and a Program ROM. Please check.