Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program counter #14

Merged
merged 4 commits into from
Jul 27, 2022
Merged

Program counter #14

merged 4 commits into from
Jul 27, 2022

Conversation

NimeshRancha
Copy link
Collaborator

Created a Program counter, a test bench for it and a Program ROM. Please check.

Copy link
Owner

@sandilsranasinghe sandilsranasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to add an I_ prefix before input names and an O_ prefix before output names too if you can.

We will use the slow clock higher up, so no need to use it here.

Comment on lines 51 to 54
component Slow_Clk
Port ( Clk_in : in STD_LOGIC;
Clk_out : out STD_LOGIC);
end component;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont use the slow clock here. Just give in the clock directly, we'll handle the clock speed in one place

Suggested change
component Slow_Clk
Port ( Clk_in : in STD_LOGIC;
Clk_out : out STD_LOGIC);
end component;

remove the rest of the signals for the slow clock too and use the clock input directly

@NimeshRancha
Copy link
Collaborator Author

Made the requested changes. Please check.

@sandilsranasinghe sandilsranasinghe merged commit 97521e1 into main Jul 27, 2022
@sandilsranasinghe sandilsranasinghe mentioned this pull request Jul 27, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants