-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sometimes text responses are gzipped, despite no Accept-Encoding header #2691
Comments
This seems to be the opposite bug of #2569, which complains that Sandstorm fails to pass through Accept-Encoding or to apply its own compression, hence lots of app assets aren't being properly compressed when they could be. So... I can't really think of why you'd get a compressed result if the app isn't the one doing it. :/ |
Okay, it looks like what's happening is that sandstorm is appending the Here are the headers that the app sees:
Vs. the headers being sent to sandstorm:
I'm trying to figure out now at what layer the erroneous |
Looks like the http-bridge will indiscriminately add sandstorm/src/sandstorm/sandstorm-http-bridge.c++ Line 1555 in 5d16982
I think this probably isn't appropriate, unless we ensure that the client can accept gzip encoding. |
Whoa. Now I'm really confused about #2569. I was observing no accept-encoding header being passed to Etherpad. Looks like the line of code you found has been there since the very beginning. I guess we need to change web-session.capnp to pass Accept-Encoding in WebSession::Context. |
I think I just hit this or something very related when troubleshooting a 403 Forbidden response from an app I'm working on, re: @timmc's experience in the linked Davros issue, a request in Firefox had the Accept-Encoding, but the response did not have a Content-Encoding header. |
I'm trying to get the davros WebDAV app working with the Mac OS X Finder. There's an issue in davros that's blocking this (mnutt/davros#74), but it looks like on a branch where that issue is fixed there's a sandstorm problem. Here's the request headers to my local sandstorm:
And, here's the response headers:
As you can see, the
Content-Encoding
is gzip, which happens to be unsupported by the client. Note that when I run the davros app locally outside sandstorm, I get identity encoding with noContent-Encoding
header, and the client works.For completeness, here are the headers for the same request from the un-sandboxed davros app:
The text was updated successfully, but these errors were encountered: