Replies: 2 comments 2 replies
-
@nirtamir2 thank you so much for creating a PR! It would be really awesome if we could implement a I'd really like to avoid patching I'm usually using |
Beta Was this translation helpful? Give feedback.
0 replies
-
@nirtamir2 I've just seen that your PR was merged solidjs/solid-start#609. As soon as your change gets released, let's get your PR merged into |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi
I want to contribute to this package and support solid-start.
I looked over your remix adapter code and found that you did not handle any regex. It is just called
remix routes
and parsing its output, which is an elegant and robust solution. Unlike remix, solid-start does not expose a command to print routes.Given the solid-start repository, I found a way to patch it to create command like
solid-start routes
that behaves like remix routes.I open a discussion in solid-start - maybe they can expose solid-start routes see solidjs/solid-start#588
Now if we patch the solid-start:
I notice you use yarn because we have
yarn.lock
file, but also you havenpm
in engines. What package manager + version do you use?I use pnpm and the patch command is supported natively (although I haven't tried it on workspace's dependency)
If you use yarn v1, I think we can use
patch-package
to modify solid-start a bit and get the routes.What you think we should do?
Testing
What is the way you test your routes-gen? I need a way to verify the plugin adapter works.
I want to help create this plugin but I'm not sure how you want to handle the packages inside
Thanks!
Beta Was this translation helpful? Give feedback.
All reactions