Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional dependancy from File::Slurper to stop warnings being printed #199

Merged
merged 1 commit into from
Nov 12, 2015

Conversation

andrewjpage
Copy link
Member

Fixes issues raised in:
#196
RT499877
RT496629

andrewjpage added a commit that referenced this pull request Nov 12, 2015
add optional dependancy from File::Slurper to stop warnings being printed
@andrewjpage andrewjpage merged commit 2ccf4ab into sanger-pathogens:master Nov 12, 2015
@satta
Copy link
Collaborator

satta commented Dec 17, 2016

FYI, it looks like the warning

Use of uninitialized value in require at /usr/lib/x86_64-linux-gnu/perl/5.24/Encode.pm line 61.

is still present when just trying:

cd t/data/genbank_gbff
roary -f /tmp/out1 *gff

This was using Roary 3.7.0 on Debian stretch.

@andrewjpage
Copy link
Member Author

Thanks for the heads up

@dutchscientist
Copy link

Can one previous version remain available on CPAN? This would allow easy testing/comparison. CPAN only contains 3.8.0 now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants