DPL-1099 Added double label for bioscan lysate plate #1635
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1635 +/- ##
===========================================
+ Coverage 90.79% 90.82% +0.02%
===========================================
Files 362 363 +1
Lines 7467 7490 +23
===========================================
+ Hits 6780 6803 +23
Misses 687 687
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| end | ||
|
|
||
| # Fetch the partner id from the first well that has a sample. | ||
| # Assumption: The partner id is stored in the sample description, and all wells woth |
| end | ||
|
|
||
| # Define the second label for the lysate plate | ||
| def intermediate_attributes |
There was a problem hiding this comment.
Would it be worth a refactor on the name of these attributes? It seems like this name was perhaps relevant to another type of label printing but I think in this case you're trying to print two labels to capture more information in the same piece of labware?
I just wouldn't know what intermediate attributes means if I was looking at this code for the first time.
There was a problem hiding this comment.
Have renamed a couple of those methods in the label class to (I think) make more sense.
I don't really follow why extra_attributes is separated (it seems to make an extra 6mm label for 384-well plates but why is that different to additional_attributes?) or what sprint_attributes is doing.
|
Code Climate has analyzed commit d75b91c and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.4% (0.1% change). View more on Code Climate. |
Closes #4019
Adds a second label for the Bioscan lysate plate which has the supplier partner plate id barcode on it that was stored in the sample metadata in sample_description.
Needs physical testing onsite.