Show both parent and child relationships on Labware

[StephenHulme]

Closes a long outstanding bug-bear.
Possibly improves #645.
Dependent on sanger/General-Backlog-Items#405

Changes proposed in this pull request

• Renames Children tab to Relatives
• Displays all immediate parents and childre with purpose, barcode, and state
• Provides easy navigation between relatives
• Removes code that was part of the previous solution
• Removes erroneously copied data-plate-view attribute

Here is a good example in UAT

Before:

After:

Instructions for Reviewers

See https://gitlab.internal.sanger.ac.uk/psd/integration-suite/-/merge_requests/154 for Integration Suite changes

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

[codecov]

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.

Project coverage is 74.90%. Comparing base (0ee4b40) to head (94d3402).
Report is 33 commits behind head on develop.

Files with missing lines	Patch %	Lines
app/frontend/javascript/legacy_scripts_a.js	0.00%	5 Missing ⚠️
...p/models/labware_creators/final_tube_from_plate.rb	0.00%	1 Missing ⚠️
...s/labware_creators/multi_stamp_library_splitter.rb	0.00%	1 Missing ⚠️
...dels/labware_creators/plate_split_to_tube_racks.rb	0.00%	1 Missing ⚠️
...pp/models/labware_creators/quadrant_split_plate.rb	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1641      +/-   ##
===========================================
- Coverage    74.95%   74.90%   -0.06%     
===========================================
  Files          420      420              
  Lines        14300    14297       -3     
===========================================
- Hits         10719    10709      -10     
- Misses        3581     3588       +7     

Flag	Coverage Δ
javascript	60.23% <0.00%> (-0.05%)	⬇️
pull_request	74.90% <35.71%> (?)
push	74.90% <35.71%> (-0.06%)	⬇️
ruby	91.15% <55.55%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sdjmchattie]

Looks good to me. I don't know the logic well enough to comment on the validity of it, but nothing jumps out as bad. Nice work!

[andrewsparkes]

This is great but can we please test it for something where there are a LOT of parents. e.g. in Bioscan the LBSN-384 PCR 2 Pool tube will have 24 parent 384-well plates.
e.g. in Cardinal the LCA Blood Array plate could have 24 parent tubes
e.g. in scRNA Core the LRC Blood Bank could have many parent tubes

[StephenHulme]

Good point @andrewsparkes, here's the updated screenshot for a LCA Blood Array plate showing how the 96 parents are handled. I have limited the heights of the parent and children boxes to 40% of the view-port height and added a scrollbar. There is now a number displayed to make it easy to count too.

And here's one for the children on a LRC PBMC Bank plate.

[KatyTaylor]

Was this one paused because it broke the integration suite selenium tests? Or was that another one? I would advocate for merging this in if we're happy it works well.

[StephenHulme]

Was this one paused because it broke the integration suite selenium tests? Or was that another one?

Yes, that's right.

Integration suite broke quite badly because it was relying on the undelying .tube-list and .plate-list classes which was refactored out of this PR.

If there is value in fixing IntSuite to try find and parse the barcode names/links themselves, then I'm happy to look at this again.

[KatyTaylor]

Was this one paused because it broke the integration suite selenium tests? Or was that another one?

Yes, that's right.

Integration suite broke quite badly because it was relying on the undelying .tube-list and .plate-list classes which was refactored out of this PR.

If there is value in fixing IntSuite to try find and parse the barcode names/links themselves, then I'm happy to look at this again.

I think there's a lot of value in this PR. Is there an issue in the backlog for this? If not, we could make one and put it forward for prioritisation? Just so that work is tracked, as it may not be trivial!

[StephenHulme]

Updated and ready for review, Integration Suite changes can be found here

[BenTopping]

Works well 👌

[codeclimate]

Code Climate has analyzed commit 94d3402 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Duplication	2

The test coverage on the diff in this pull request is 55.5% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.1% (0.0% change).

View more on Code Climate.