DPL-1047-18: Upgrade Node to v18 (as a stepping stone) #1645
Conversation
StephenHulme
force-pushed
the
dpl-1047-18-upgrade
branch
from
9439fb5
to
3db2bab
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dpl-1047-16-upgrade #1645 +/- ##
=======================================================
+ Coverage 91.40% 91.48% +0.07%
=======================================================
Files 376 378 +2
Lines 7656 7713 +57
=======================================================
+ Hits 6998 7056 +58
+ Misses 658 657 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
StephenHulme
force-pushed
the
dpl-1047-18-upgrade
branch
from
78e0093
to
21f453b
Compare
|
Version 18 checklist:
|
$ bin/vite dev Your `bin/bundle` was not generated by Bundler, so this binstub cannot run. Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.
| @@ -76,14 +80,16 @@ | |||
| .aliquot:hover { | |||
| color: #ffd600; | |||
| cursor: pointer; | |||
| @extend .selected-aliquot; | |||
| // @extend .selected-aliquot; // TODO: Remove circular reference | |||
There was a problem hiding this comment.
This should be checked in UAT, likely related to failing wells
| })(window,jQuery); | ||
| </script> | ||
| <div id="labware-creator-config" | ||
| data-tag-plates-list="<%= @labware_creator.tag_plates_list.to_json %>" |
There was a problem hiding this comment.
Check if quoted quotes work with .to_json
Co-authored-by: Stuart McHattie <sm49@sanger.ac.uk>
I suspect this is not actually used in production... See deployment:/roles/deploy_limber/templates/environment_template.rb.j2
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 2257718 and detected 92 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 91.1% (0.0% change). View more on Code Climate. |
Moves closer to closing #1541, as upgrading to v20 is non-trivial (see #1555)
This PR is built on top of the Node 16 upgrade PR
Changes proposed in this pull request
Deployment Instructions
Developer Hints
Run this command from the repository's root directory to remove old coverage and build files:
rm -r app/javascript/coverage/ public/packs*/ public/assets/These are auto-generated, so nothing should be lost.
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version