Y24-042 scRNA - Fix bug in file handling #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1661 +/- ##
===========================================
+ Coverage 90.83% 93.65% +2.82%
===========================================
Files 363 42 -321
Lines 7494 930 -6564
===========================================
- Hits 6807 871 -5936
+ Misses 687 59 -628
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
KatyTaylor
approved these changes
Apr 4, 2024
...models/labware_creators/common_file_handling/csv_file/row_for_tube_rack_with_rack_barcode.rb
Show resolved
Hide resolved
|
Code Climate has analyzed commit 641044b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 94.4% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.4% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1659
Changes proposed in this pull request
Fix for bug to do with routing when displaying errors when creating Crystor plate.
Change to expect csv file upload to contain a tube rack barcode column.