-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Y24-035 tnanoseq update configs for pipeline #1711
Y24-035 tnanoseq update configs for pipeline #1711
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1711 +/- ##
===========================================
+ Coverage 91.38% 91.43% +0.04%
===========================================
Files 373 373
Lines 7686 7714 +28
===========================================
+ Hits 7024 7053 +29
+ Misses 662 661 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ment to purpose factory
…s match the rows uploaded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
…ts in submission, and rows with pcr_cycles = 1 are ignored
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest changes for allowing to leave rows in file but set pic_cycles to 1 to ignore them look good. I have inserted binding.pry in several places and inspected the changes as well. The update clearly excludes rows with pcr_cycles set to 1 before comparing active requests and customer file wells, for validations. There are enough code comments.
Type info in comments, params, returns would make them better.
Code Climate has analyzed commit eaac64f and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 91.1% (0.0% change). View more on Code Climate. |
Closes #1646
Changes proposed in this pull request
Updates config to allow Targeted NanoSeq to use ReISC and to loop with submissions.