Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-037 Cell count spot-checking #1739

Merged
merged 101 commits into from
Jun 28, 2024
Merged

Conversation

yoldas
Copy link
Member

@yoldas yoldas commented Jun 17, 2024

Closes #

Changes proposed in this pull request

  • Algorithm to select wells from bins across the plate for even distribution.
  • Downloads for 4, 6, 12, and ALL count well selections (export links work for testing the alternatives)
  • Download buttons on the page are for 4 and ALL counts. One well per Vac tube is selected in every case.
  • First sample uuids are used for matching the ancestor vac tubes and wells..
  • Removed 4 existing Cellaca download buttons
  • QC barcode labels are not touched
  • Well name is moved to last in CSV, based on feedback
  • There is a workflow header followed by a new line
  • A state based feature enabling is implemented and download buttons for content report and Seq/Spare options are enabled in passed and qc_complete states only using purpose config.
  • Buttons labels are named slightly different to distinguish from others. [From feedback, naming option is selected; not colour styling]

Others:

  • There are so many commits about dynamic file naming based on config and URL params; That idea was abandoned.
  • Integration suite is not updated yet.

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@yoldas yoldas linked an issue Jun 17, 2024 that may be closed by this pull request
17 tasks
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.35%. Comparing base (3c349ce) to head (35611b8).
Report is 20 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1739      +/-   ##
===========================================
+ Coverage    91.26%   91.35%   +0.09%     
===========================================
  Files          369      372       +3     
  Lines         7581     7660      +79     
===========================================
+ Hits          6919     6998      +79     
  Misses         662      662              
Flag Coverage Δ
javascript 93.65% <ø> (ø)
pull_request 91.35% <100.00%> (?)
push 91.35% <100.00%> (+0.08%) ⬆️
ruby 91.04% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@KatyTaylor KatyTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started re-reviewing but wasn't sure if it's up to date, as the binning algorithm parts look the same, and I thought you said you re-wrote them? thanks

app/models/presenters/standard_presenter.rb Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Jun 26, 2024

Code Climate has analyzed commit 35611b8 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.0% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@KatyTaylor KatyTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments but approving as they are small.

@yoldas yoldas merged commit a715402 into develop Jun 28, 2024
12 checks passed
@yoldas yoldas deleted the 1653-y24-037-cell-count-spot-checking branch June 28, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y24-037 Cell count spot-checking
3 participants