-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Y24-037 Cell count spot-checking #1739
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1739 +/- ##
===========================================
+ Coverage 91.26% 91.35% +0.09%
===========================================
Files 369 372 +3
Lines 7581 7660 +79
===========================================
+ Hits 6919 6998 +79
Misses 662 662
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…pplier name for ancestor vac tube barcodes instead of ancestor_tubes as requested in code review
…essing ancestor_tubes via sample_uuid after code review comments
…r vac tube barcode as requested in code review comments
…c tube barcode as requested in code review comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started re-reviewing but wasn't sure if it's up to date, as the binning algorithm parts look the same, and I thought you said you re-wrote them? thanks
app/models/concerns/presenters/statemachine/feature_in_states.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: KatyTaylor <kt17@sanger.ac.uk>
…ed in Presenter concern
…n the Presenter concern
…ed in the Presenter concern
Code Climate has analyzed commit 35611b8 and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 91.0% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments but approving as they are small.
Closes #
Changes proposed in this pull request
Others:
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main
]- Check story numbers included
- Check for debug code
- Check version