Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing support for endNumber inside MultipleSegmentBase #57

Merged
merged 2 commits into from
Mar 5, 2022

Conversation

wreszelewski
Copy link
Contributor

Hi!
Thanks for this lib! I needed to use endNumber property of MultipleSegmentBase, which was missing, so I added it.
Could you merge this into main repo and release new version to PyPi?

@sangwonl
Copy link
Owner

sangwonl commented Mar 4, 2022

Thanks @wreszelewski for your support.

By the way, I don't see the field endNumber from DASH-MPD standard schema file. So, I'm not sure if we can include this field. Can someone comment on it?

cc: @davemevans

@davemevans
Copy link
Collaborator

davemevans commented Mar 4, 2022

Seems that schema file available at that link has not been updated to match the current (4th) edition of the DASH spec - it only seems to match the 2nd edition.

4th Edition schema is available at https://standards.iso.org/iso-iec/23009/-1/ed-4/en/DASHSchema-4th-Ed.zip (link is in the spec) and includes endNumber.

@sangwonl
Copy link
Owner

sangwonl commented Mar 5, 2022

Seems that schema file available at that link has not been updated to match the current (4th) edition of the DASH spec - it only seems to match the 2nd edition.

4th Edition schema is available at https://standards.iso.org/iso-iec/23009/-1/ed-4/en/DASHSchema-4th-Ed.zip (link is in the spec) and includes endNumber.

Thanks, now I understood. We need to update our schema file.

Copy link
Owner

@sangwonl sangwonl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wreszelewski for the updated thing, I will merge this PR.

PS) Will create an issue and follow the update.

@sangwonl sangwonl merged commit 48b5212 into sangwonl:master Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants