Add msgspec support for openapi.Component and @validate() #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 14, 2023 11:09
Validation only occurs when using msgspec.convert, so type errors would not be properly caught without the new _msgspec_validate_instance method
ahopkins
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for using msgspec in
openapi.Componentand with validation --@validate()I also parameterized the tests in
test_validationto verify thatmsgspecworked, but I also added the equivalentattrsandpydantictests as well to make sure that all cases were covered.If I wasn't sure about compatibility, I used inline imports -- as opposed to top-of-file imports -- for
msgspec.