Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

Update app.md and listeners.md #47

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Update app.md and listeners.md #47

merged 2 commits into from
Jun 1, 2021

Conversation

ProgramRipper
Copy link
Contributor

Added some missing words.
补充了一些漏字、漏词。


BTW, there is a strange phenomenon on "headers" page. Both en and zh
顺便一提,在“标头(Headers)”这一页面上有一奇怪的现象,在英语和中文页面中都有。
image
image
The contents of the red and blue boxes are exactly the same, but I didn't find out the reason from the source code. I think this may be due to the rendering error of the Markdown file.
红蓝两框的内容是完全一致的,但我没有在源码中找到原因。我想这也许是因为Markdown文件的渲染出错。

@ahopkins ahopkins requested a review from a team June 1, 2021 10:49
@ahopkins
Copy link
Member

ahopkins commented Jun 1, 2021

Thanks for the PR. I think I have noticed this once before about the headers page. I will see if I can figure it out.

@ZinkLu
Copy link
Member

ZinkLu commented Jun 1, 2021

@ProgramRipper Thanks for the PR. 感谢老铁。

@ZinkLu ZinkLu merged commit b8fa43d into sanic-org:main Jun 1, 2021
@ahopkins
Copy link
Member

ahopkins commented Jun 1, 2021

I figured it out.... it seems to be a problem when going from a list to columns:

- `content-length`
- `content-type`
- `connection`
- `transfer-encoding`


---:1

Any other header that you would like to set can be done either in the route handler, or a response middleware.

:--:1

...
:---

If I add an arbitrary line of text after the list, it renders as expected 🤷‍♂️

@ahopkins
Copy link
Member

ahopkins commented Jun 1, 2021

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants