Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v23.3 Deprecation Removal #2717

Merged
merged 9 commits into from
Mar 26, 2023
Merged

v23.3 Deprecation Removal #2717

merged 9 commits into from
Mar 26, 2023

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Mar 19, 2023

  • duplicate names
  • duplicate exception handler definition
  • inspector CLI with flags
  • legacy server (including sanic.server.serve_single and sanic.server.serve_multiple)
  • serving directory with bytes string
  • Request.request_middleware_started
  • Websocket.connection

@ahopkins ahopkins marked this pull request as ready for review March 21, 2023 20:33
@ahopkins ahopkins requested a review from a team as a code owner March 21, 2023 20:33
@ahopkins ahopkins marked this pull request as draft March 23, 2023 12:46
Tronic
Tronic previously approved these changes Mar 23, 2023
Copy link
Member

@Tronic Tronic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct but I didn't dig into all the removed server code.

@ahopkins ahopkins marked this pull request as ready for review March 26, 2023 09:51
@ahopkins ahopkins requested a review from a team as a code owner March 26, 2023 12:01
@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Patch coverage: 100.000% and project coverage change: +0.169 🎉

Comparison is base (a8c2d77) 88.776% compared to head (b7c4269) 88.946%.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2717       +/-   ##
=============================================
+ Coverage   88.776%   88.946%   +0.169%     
=============================================
  Files           92        92               
  Lines         7039      6957       -82     
  Branches      1198      1185       -13     
=============================================
- Hits          6249      6188       -61     
+ Misses         542       527       -15     
+ Partials       248       242        -6     
Impacted Files Coverage Δ
sanic/app.py 90.119% <100.000%> (+0.016%) ⬆️
sanic/blueprints.py 91.387% <100.000%> (+0.254%) ⬆️
sanic/handlers/error.py 97.402% <100.000%> (+0.034%) ⬆️
sanic/mixins/startup.py 92.753% <100.000%> (+1.946%) ⬆️
sanic/mixins/static.py 89.928% <100.000%> (ø)
sanic/request/types.py 94.752% <100.000%> (+0.515%) ⬆️
sanic/router.py 96.000% <100.000%> (+0.166%) ⬆️
sanic/server/__init__.py 100.000% <100.000%> (ø)
sanic/server/runners.py 89.285% <100.000%> (+0.129%) ⬆️
sanic/server/websockets/impl.py 38.372% <100.000%> (-0.108%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins merged commit d680af3 into main Mar 26, 2023
@ahopkins ahopkins deleted the deprecations-23.3 branch March 26, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants