-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversion of User Guide to the SHH stack #2781
Conversation
It's a very large diff. Clearly this does something other than html5tagger and htmx? Should also cover msgspec in docs. Staying unopionated, JS fronts like htmx (with html5tagger) and vue (with msgspec) should probably be left to their separate tutorial pages, rather than discussed in the main guide. The same goes for databases (urgently needed in practice, still with poor async support). |
@Tronic I think you misunderstood what this branch is. It is an attempt to drop
No disagreement. Sanic does not take an opinion. But, clearly in building its own site it needs to make some decisions. In the past it was was Sphinx with RTD. Then vuepress with GH. I am proposing a POC for how we can serve https://sanic.dev using Sanic.
Make the suggestion and discussion here: https://github.com/sanic-org/sanic-guide. That is somewhat irrelevant since it is a copy/past with changes only to handle a difference in Markdown extras.
Same. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2781 +/- ##
=============================================
- Coverage 88.689% 88.429% -0.261%
=============================================
Files 92 92
Lines 7082 7156 +74
Branches 1214 1228 +14
=============================================
+ Hits 6281 6328 +47
- Misses 551 574 +23
- Partials 250 254 +4
☔ View full report in Codecov by Sentry. |
This brings the User Guide into the
sanic
repo, and builds it using Sanic, html5tagger, and htmx. It provides:It is a massive PR, but it is all documentation, and not really a change at that.