Make request.scheme return ws/wss for WS even when http/https in SERVER_NAME or proxy headers #2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tronic
changed the title
ahopkins
previously approved these changes
Nov 28, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2854 +/- ##
=============================================
+ Coverage 88.219% 88.231% +0.011%
=============================================
Files 93 93
Lines 7275 7282 +7
Branches 1249 1251 +2
=============================================
+ Hits 6418 6425 +7
- Misses 598 599 +1
+ Partials 259 258 -1 ☔ View full report in Codecov by Sentry. |
ahopkins
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it would work as expected locally, but if the scheme was sourced from full URL SERVER_NAME or proxied forwarded headers, incorrect URLs were returned.