Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better exception on multiprocessing context conflicts #2875

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

ahopkins
Copy link
Member

Since Sanic tries to set the multiprocessing context, there is a more clear error when something goes wrong. This will point the user to the docs for how to deal with the issue.

@ahopkins ahopkins requested review from a team as code owners December 11, 2023 10:43
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (160ec7a) 88.217% compared to head (00f536c) 88.215%.
Report is 1 commits behind head on main.

Files Patch % Lines
sanic/app.py 81.818% 1 Missing and 1 partial ⚠️
sanic/mixins/startup.py 77.777% 1 Missing and 1 partial ⚠️
sanic/mixins/listeners.py 94.736% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2875       +/-   ##
=============================================
- Coverage   88.217%   88.215%   -0.002%     
=============================================
  Files           93        93               
  Lines         7282      7298       +16     
  Branches      1251      1254        +3     
=============================================
+ Hits          6424      6438       +14     
  Misses         600       600               
- Partials       258       260        +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahopkins ahopkins merged commit 0663f11 into main Dec 11, 2023
26 checks passed
@ahopkins ahopkins deleted the multiprocess-context-safety branch December 11, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant