-
Notifications
You must be signed in to change notification settings - Fork 34
fix(types): add import release action type #1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Coverage Report
File Coverage
|
Don't know these actions well enough to review, will leave it to @rdyv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
release.import
is used by dataset import to create a new release system document and populate it with the provided attributes based on the state of the release.
Do you plan on using it for something else besides the cli import command? Or is this just a typescript change?
Just adding the types for the import CLI. See context sanity-io/import#20 (comment) |
b485c5b
to
ce50ea4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TL;DR
Added support for importing releases with a new
ImportReleaseAction
type. Please correct me if I am wrongWhat changed?
ImportReleaseAction
interface to the types systemReleaseAction
union typeifExists
)How to test?
ImportReleaseAction
type in your codeactionType: 'sanity.action.release.import'
ifExists
strategies ('fail', 'ignore', 'replace')Why make this change?
This change enables importing existing documents into releases, providing flexibility in how content is managed across environments. The
ifExists
parameter gives users control over conflict resolution when importing documents that may already exist in a release.