Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix printer to use object access syntax for reserved words #5

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Fix printer to use object access syntax for reserved words #5

merged 1 commit into from
Apr 12, 2023

Conversation

atombender
Copy link
Member

Fixes printer for expressions like foo.true to use foo["true"] instead. This is probably temporary, until we can agree on reserved word usage and update the spec and fix the parsers to parse foo.true as intended.

@atombender
fix: fix printer to use object access syntax for reserved words
0d19fbb 
(e.g. foo.true -> foo["true"]) until spec is fixed.
@atombender atombender self-assigned this Oct 5, 2022
@atombender atombender requested a review from a team November 8, 2022 12:39
@atombender atombender merged commit 7a5646f into main Apr 12, 2023
@atombender atombender deleted the reserved-word-quoting branch April 12, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@judofyr judofyr judofyr approved these changes

Assignees

@atombender atombender

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atombender @judofyr