feat: can extract attribute key from Group #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgulseth
changed the title
sgulseth
force-pushed
the
feat/extract-attribute-keys
branch
from
c5cd5cb
to
c1526c9
Compare
sgulseth
changed the title
|
Oh, interesting. Seems like a bug in GROQ spec as well? |
|
mhm. I'll add group and the other missing types |
judofyr
approved these changes
Aug 29, 2024
sgulseth
force-pushed
the
feat/extract-attribute-keys
branch
from
c1526c9
to
d6648c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to make sure we align with https://sanity-io.github.io/GROQ/draft/#DetermineName()