-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add number, string and block content icon #2
Conversation
export/block-content.svg
Outdated
@@ -0,0 +1,7 @@ | |||
<svg width="26" height="25" viewBox="0 0 26 25" fill="none" xmlns="http://www.w3.org/2000/svg"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, the viewBox
of this SVG should be 0 0 25 25
– similarly, width should be 25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(You may also need to revisit paths after changing this!)
src/icons/blockContentIcon.tsx
Outdated
fillRule="evenodd" | ||
clipRule="evenodd" | ||
d="M21.0126 7.59999L11.0126 7.59999V6.39999L21.0126 6.39999V7.59999Z" | ||
fill="#101112" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All generated icon components should use currentColor
This should be possible by adjusting the colour of the source SVGs to #121923
, after which the icon build process will substitute those values with currentColor
, see:
Lines 80 to 83 in 5719430
// Replace Sanity black hex value with `currentColor` | |
code = code | |
.replace(/"#121923"/g, '"currentColor"') | |
.replace('<svg ', `<svg data-sanity-icon="${name}" `) |
Thanks @jorngeorg! Will leave it to Marius to comment on aesthetics, asides from the above comments it all LGTM |
Thanks, @robinpyon! Fixed the currentColor and viewBox issues. |
cd7f9e2
to
1be8db2
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR adds three new icons
block-content
,string
, andnumber
that will primarily be used to denote different fields types.What to review:
input
to the name to be more specific, e.g.StringInputIcon
)